Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/renderer/resources/extensions/page_action_custom_bindings.js

Issue 11571014: Lazy load chrome.* APIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments/TODOs Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/page_action_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/page_action_custom_bindings.js b/chrome/renderer/resources/extensions/page_action_custom_bindings.js
index b52737467017ecc252e65ec67c346d70825ab9f7..dbec70c42889d5416a62cfb4f87290daa9b431ff 100644
--- a/chrome/renderer/resources/extensions/page_action_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/page_action_custom_bindings.js
@@ -4,10 +4,11 @@
// Custom bindings for the pageAction API.
-var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
+var bindings = new (require('schema_binding_generator').Bindings)('pageAction');
+
var setIcon = require('setIcon').setIcon;
-chromeHidden.registerCustomHook('pageAction', function(bindingsAPI) {
+bindings.registerCustomHook(function(bindingsAPI) {
var apiFunctions = bindingsAPI.apiFunctions;
apiFunctions.setHandleRequest('setIcon', function(details, callback) {
@@ -15,3 +16,5 @@ chromeHidden.registerCustomHook('pageAction', function(bindingsAPI) {
'page action');
});
});
+
+exports.bindings = bindings.generate();

Powered by Google App Engine
This is Rietveld 408576698