Lazy load chrome.* APIs

chrome/renderer/extensions/schema_generated_native_handler.cc

Index: chrome/renderer/extensions/schema_generated_native_handler.cc
diff --git a/chrome/renderer/extensions/schema_generated_native_handler.cc b/chrome/renderer/extensions/schema_generated_native_handler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..140881928b2fa0a43db6285a1f9a7083ac729688
--- /dev/null
+++ b/chrome/renderer/extensions/schema_generated_native_handler.cc
@@ -0,0 +1,40 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/renderer/extensions/schema_generated_native_handler.h"
+
+#include "chrome/renderer/extensions/module_system.h"
+#include "chrome/renderer/extensions/v8_schema_registry.h"
+
+namespace extensions {
+
+SchemaGeneratedNativeHandler::SchemaGeneratedNativeHandler(
+    ModuleSystem* module_system,
+    V8SchemaRegistry* schema_registry,
+    const std::string& api_name,
+    const std::string& bind_to)
+    : module_system_(module_system),
+      schema_registry_(schema_registry),
+      api_name_(api_name),
+      bind_to_(bind_to) {
+}
+
+v8::Handle<v8::Object> SchemaGeneratedNativeHandler::NewInstance() {
+  v8::Handle<v8::Value> module =

[not at google - send to devlin, 2013/01/25 00:44:31]

schema_binding_generator

[cduvall, 2013/02/12 02:13:47]

Done.

+      module_system_->Require("schema_binding_generator");
+  v8::Local<v8::Value> func =

[not at google - send to devlin, 2013/01/25 00:44:31]

generate

[cduvall, 2013/02/12 02:13:47]

Done.

+      v8::Handle<v8::Object>::Cast(module)->Get(
+          v8::String::New("generate"));
+
+  v8::Handle<v8::Value> argv[] = {
+    schema_registry_->GetSchema(api_name_)
+  };

[not at google - send to devlin, 2013/01/25 00:44:31]

Ok now I see why you need the "generate" function on schema_binding_generator as
well as on Binding.

I think we should do this slightly differently. Make Binding take the schema in
its constructor rather than the string, then use that here (it's slightly more
verbose, but not that bad).

Then give Binding a method like Create which takes the string.

I also think the custom bindings will look a bit nicer that way, like

var binding = require('schema_binding_generator').Binding.Create('foo');

which makes me think that perhaps the file should just be called "binding" not
"schema_binding_generator", and this class actually called
BindingGeneratingNativeHandler.

[cduvall, 2013/02/12 02:13:47]

Done.

+  v8::Handle<v8::Value> compiled_schema =
+      module_system_->CallModuleMethod(func, 1, argv);
+  v8::Handle<v8::Object> object = v8::Object::New();
+  object->Set(v8::String::New(bind_to_.c_str()), compiled_schema);
+  return object;
+}
+
+} // extensions