Lazy load chrome.* APIs

chrome/renderer/extensions/chrome_v8_context.cc

Index: chrome/renderer/extensions/chrome_v8_context.cc
diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc
index e23ead53dfcc82f00e7bea9778714e736862fd4a..6da1a183fba291824e3914292c1d6dbe45b8b6c9 100644
--- a/chrome/renderer/extensions/chrome_v8_context.cc
+++ b/chrome/renderer/extensions/chrome_v8_context.cc
@@ -143,12 +143,11 @@ bool ChromeV8Context::CallChromeHiddenMethod(
 
 const std::set<std::string>& ChromeV8Context::GetAvailableExtensionAPIs() {
   if (!available_extension_apis_.get()) {
-    available_extension_apis_ =
+    available_extension_apis_.reset(new std::set<std::string>(

[not at google - send to devlin, 2013/01/24 21:10:12]

available_extension_apis_.swap(GetAPIsForContext...)

[cduvall, 2013/01/24 22:15:15]

GetAPIsForContext doesn't return a scoped_ptr, so I think this should still be
reset, right?

[not at google - send to devlin, 2013/01/25 00:44:31]

Ah, I mean for available_extension_apis to be just a set not a scoped_ptr<set>,
probably with a separate bool to say whether it's initialized (since it seems
conceivable that it initialises to empty).

         ExtensionAPI::GetSharedInstance()->GetAPIsForContext(
             context_type_,
             extension_,
-            UserScriptSlave::GetDataSourceURLForFrame(
-                web_frame_)).Pass();
+            UserScriptSlave::GetDataSourceURLForFrame(web_frame_))));
   }
   return *(available_extension_apis_.get());
 }