Lazy load chrome.* APIs

chrome/renderer/extensions/chrome_v8_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_v8_context.h"
 
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/string_split.h"
 #include "base/values.h"
@@ skipping 125 matching lines @@
                                                    argc,
                                                    argv);
   if (result)
     *result = result_temp;
 
   return true;
 }
 
 const std::set<std::string>& ChromeV8Context::GetAvailableExtensionAPIs() {
   if (!available_extension_apis_.get()) {
-    available_extension_apis_ =
+    available_extension_apis_.reset(new std::set<std::string>(

[not at google - send to devlin, 2013/01/24 21:10:12]

available_extension_apis_.swap(GetAPIsForContext...)

[cduvall, 2013/01/24 22:15:15]

GetAPIsForContext doesn't return a scoped_ptr, so I think this should still be
reset, right?

[not at google - send to devlin, 2013/01/25 00:44:31]

Ah, I mean for available_extension_apis to be just a set not a scoped_ptr<set>,
probably with a separate bool to say whether it's initialized (since it seems
conceivable that it initialises to empty).

         ExtensionAPI::GetSharedInstance()->GetAPIsForContext(
             context_type_,
             extension_,
-            UserScriptSlave::GetDataSourceURLForFrame(
-                web_frame_)).Pass();
+            UserScriptSlave::GetDataSourceURLForFrame(web_frame_))));
   }
   return *(available_extension_apis_.get());
 }
 
 void ChromeV8Context::DispatchOnLoadEvent(bool is_incognito_process,
                                           int manifest_version) {
   v8::HandleScope handle_scope;
   v8::Handle<v8::Value> argv[] = {
     v8::String::New(GetExtensionID().c_str()),
     v8::String::New(GetContextTypeDescription().c_str()),
@@ skipping 14 matching lines @@
     case Feature::BLESSED_EXTENSION_CONTEXT:   return "BLESSED_EXTENSION";
     case Feature::UNBLESSED_EXTENSION_CONTEXT: return "UNBLESSED_EXTENSION";
     case Feature::CONTENT_SCRIPT_CONTEXT:      return "CONTENT_SCRIPT";
     case Feature::WEB_PAGE_CONTEXT:            return "WEB_PAGE";
   }
   NOTREACHED();
   return "";
 }
 
 }  // namespace extensions