Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 11571004: Implement is-checks for static functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address Nicolas' comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
index fe8c5eeece7e28ffb77339d9aeaf72ba26473117..06b6576cdffe7ded824602c88cd2f35d6107d080 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
@@ -2270,6 +2270,11 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
push(new js.Binary('==', pop(), new js.LiteralNull()));
}
+ void checkNonNull(HInstruction input) {
+ use(input);
+ push(new js.Binary('!=', pop(), new js.LiteralNull()));
+ }
+
void checkFunction(HInstruction input, DartType type) {
checkTypeOf(input, '===', 'function');
js.Expression functionTest = pop();
@@ -2394,6 +2399,12 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
|| Elements.isListSupertype(element, compiler)) {
handleListOrSupertypeCheck(input, type);
attachLocationToLast(node);
+ } else if (element.isTypedef()) {
+ checkNonNull(input);
+ js.Expression nullTest = pop();
+ checkType(input, type);
+ push(new js.Binary('&&', nullTest, pop()));
+ attachLocationToLast(node);
} else if (types[input].canBePrimitive() || types[input].canBeNull()) {
checkObject(input, '===');
js.Expression objectTest = pop();
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698