Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1157093003: Handle Delete of element with LookupIterator (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Handle Delete of element with LookupIterator BUG=v8:4137 LOG=n Committed: https://crrev.com/bda7fb22465fc36d99b4053f0ef60cfaa8441209 Cr-Commit-Position: refs/heads/master@{#28762}

Patch Set 1 #

Patch Set 2 : Remove stale comment #

Patch Set 3 : Rebase, fix all strong-mode handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -279 lines) Patch
M src/elements.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/elements.cc View 1 2 11 chunks +24 lines, -60 lines 0 comments Download
M src/lookup.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 chunks +3 lines, -13 lines 0 comments Download
M src/objects.cc View 1 2 4 chunks +90 lines, -190 lines 0 comments Download
M src/objects-inl.h View 1 2 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Toon Verwaest
ptal
5 years, 7 months ago (2015-05-26 15:37:52 UTC) #2
Toon Verwaest
Rebased
5 years, 6 months ago (2015-06-02 08:51:08 UTC) #3
Igor Sheludko
lgtm
5 years, 6 months ago (2015-06-02 11:01:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157093003/40001
5 years, 6 months ago (2015-06-02 11:26:14 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-02 11:52:37 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 11:52:50 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bda7fb22465fc36d99b4053f0ef60cfaa8441209
Cr-Commit-Position: refs/heads/master@{#28762}

Powered by Google App Engine
This is Rietveld 408576698