Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2116)

Unified Diff: src/elements.h

Issue 1157093003: Handle Delete of element with LookupIterator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase, fix all strong-mode handling Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index 1065b1f73df63aa492a766cefa3e309dbbf2bb64..49faeab0dbd04012b87de6d22067e5cb72040b10 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -102,9 +102,9 @@ class ElementsAccessor {
int capacity,
int length) = 0;
- // Deletes an element in an object, returning a new elements backing store.
- MUST_USE_RESULT virtual MaybeHandle<Object> Delete(
- Handle<JSObject> holder, uint32_t key, LanguageMode language_mode) = 0;
+ // Deletes an element in an object.
+ virtual void Delete(Handle<JSObject> holder, uint32_t key,
+ LanguageMode language_mode) = 0;
// If kCopyToEnd is specified as the copy_size to CopyElements, it copies all
// of elements from source after source_start to the destination array.
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698