Issue 115704: Change URL back to the previous one if the typed URL causes file download....

Issue 115704: Change URL back to the previous one if the typed URL causes file download.... (Closed)

Created:
11 years, 7 months ago by yuzo

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Change URL back to the previous one if the typed URL causes file download. TESTED=manually TEST=Type any URL that causes download, e.g., ftp://ftp.vim.org/pub/vim/pc/gvim72.zip into the omnibox. Without this change the URL remains there. With this change, the URL is changed back to the original one. BUG=1904

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -4 lines)			Patch
M	chrome/browser/renderer_host/buffered_resource_handler.h	View	1 2	2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/buffered_resource_handler.cc	View	1 2 3	4 chunks	+18 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/resource_dispatcher_host.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/navigation_entry.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 2	2 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_util.cc	View	3 4	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

yuzo

Hi, Brett, Can you review this? I'm not really sure if this is a good ...

11 years, 7 months ago (2009-05-22 10:08:16 UTC) #1

darin (slow to review)

I think this is fairly reasonable UX. It is important for the URL bar to ...

11 years, 7 months ago (2009-05-25 07:31:02 UTC) #3

yuzo

Darin, Thank you very much for your review. Can you take another look? Yuzo http://codereview.chromium.org/115704/diff/12/1014 ...

11 years, 7 months ago (2009-05-25 10:42:24 UTC) #4

yuzo

Uncommented the DCHECK_EQ in tab_util, because a unit test fails with the following message: [ ...

11 years, 7 months ago (2009-05-25 11:29:16 UTC) #5

brettw

What happens when a download happens in the background? I'm not sure how this normally ...

11 years, 6 months ago (2009-05-29 19:17:53 UTC) #6

yuzo

Hi, Brett, Thank you for the review. As far as I tested several cases, this ...

11 years, 6 months ago (2009-06-01 07:34:47 UTC) #7

yuzo

Thank you for your review. Can you commit this when you have time? Yuzo

11 years, 6 months ago (2009-06-03 01:59:53 UTC) #9

brettw

I just noticed something. You added a dependency on tab_contents from the buffered_resource_handler. The dependencies ...

11 years, 6 months ago (2009-06-03 19:25:18 UTC) #10

yuzo

Hi, Brett, Thank you for your comments. I've followed your advice and added a notification. ...

11 years, 6 months ago (2009-06-08 06:15:24 UTC) #11

brettw

Sorry I lost this! If I understand you properly, you broadcast a notification with the ...

11 years, 6 months ago (2009-06-17 05:12:09 UTC) #13

yuzo

11 years, 6 months ago (2009-06-17 09:47:08 UTC) #14

This has been superseded by:
http://codereview.chromium.org/126266
(Moved to my writeable svn workspace)

Expand Messages | Collapse Messages