Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2198)

Unified Diff: chrome/browser/tab_contents/tab_util.cc

Issue 115704: Change URL back to the previous one if the typed URL causes file download.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/tab_util.cc
===================================================================
--- chrome/browser/tab_contents/tab_util.cc (revision 16844)
+++ chrome/browser/tab_contents/tab_util.cc (working copy)
@@ -29,6 +29,11 @@
TabContents* tab_util::GetTabContentsByID(int render_process_id,
int render_view_id) {
+ // Ensures that that this method is only ever called on the UI thread.
+
+ // TODO(yuzo): Fix the callers and uncomment the following.
+ // DCHECK_EQ(MessageLoop::TYPE_UI, MessageLoop::current()->type());
+
RenderViewHost* render_view_host =
RenderViewHost::FromID(render_process_id, render_view_id);
if (!render_view_host)
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698