Issue 1157033008: Normalize hostnames before searching for HSTS/HPKP preloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1157033008: Normalize hostnames before searching for HSTS/HPKP preloads (Closed)

Created:
5 years, 6 months ago by Ryan Sleevi

Modified:
5 years, 6 months ago

Reviewers:
davidben

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

More Reviews

Description

Normalize hostnames before searching for HSTS/HPKP preloads The HSTS/HPKP preload set is pre-normalized at construction time. Since the queries come from the GURL, not from the DNS layer, we need to normalize the hostname before scanning for preloads. This used to be handled by CanonicalizeHost(), which used the same mechanism as the resolver, but the storage of the preloads has changed to be more efficient, and thus no longer uses the resolver-normalized form. BUG=461481 R=davidben@chromium.org Review URL: https://codereview.chromium.org/1149753002 Cr-Commit-Position: refs/heads/master@{#330834} (cherry picked from commit c2dd599bdd35753da237172dc37a447e9d65c463) Committed: https://chromium.googlesource.com/chromium/src/+/e648e4b5848efceda338aff4d83819ce9b34c456

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+304 lines, -224 lines)			Patch
M	net/http/transport_security_state.h	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	net/http/transport_security_state.cc	View	6 chunks	+240 lines, -217 lines	0 comments	Download
M	net/http/transport_security_state_unittest.cc	View	2 chunks	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

5 years, 6 months ago (2015-06-05 06:32:31 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e648e4b5848efceda338aff4d83819ce9b34c456.

Expand Messages | Collapse Messages