Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(144)

Issue 1149753002: Normalize hostnames before searching for HSTS/HPKP preloads (Closed)

Created:
4 years, 6 months ago by Ryan Sleevi
Modified:
4 years, 6 months ago
Reviewers:
davidben
CC:
cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Normalize hostnames before searching for HSTS/HPKP preloads The HSTS/HPKP preload set is pre-normalized at construction time. Since the queries come from the GURL, not from the DNS layer, we need to normalize the hostname before scanning for preloads. This used to be handled by CanonicalizeHost(), which used the same mechanism as the resolver, but the storage of the preloads has changed to be more efficient, and thus no longer uses the resolver-normalized form. BUG=461481 R=davidben@chromium.org Committed: https://crrev.com/c2dd599bdd35753da237172dc37a447e9d65c463 Cr-Commit-Position: refs/heads/master@{#330834}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address nits (but badly) #

Patch Set 3 : ODR cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -224 lines) Patch
M net/http/transport_security_state.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M net/http/transport_security_state.cc View 1 2 6 chunks +240 lines, -217 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 2 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Ryan Sleevi
For your review
4 years, 6 months ago (2015-05-20 18:31:54 UTC) #1
davidben
Just a bunch of nits and the CanonicalizeHost thing. https://codereview.chromium.org/1149753002/diff/1/net/http/transport_security_state.cc File net/http/transport_security_state.cc (left): https://codereview.chromium.org/1149753002/diff/1/net/http/transport_security_state.cc#oldcode301 net/http/transport_security_state.cc:301: ...
4 years, 6 months ago (2015-05-20 19:21:09 UTC) #2
Ryan Sleevi
Done. I split this into two patchsets - one in which I just make CanonicalizeHost ...
4 years, 6 months ago (2015-05-20 19:26:40 UTC) #3
davidben
lgtm
4 years, 6 months ago (2015-05-20 19:39:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149753002/40001
4 years, 6 months ago (2015-05-20 19:44:19 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2015-05-20 23:29:14 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2015-05-20 23:30:50 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c2dd599bdd35753da237172dc37a447e9d65c463
Cr-Commit-Position: refs/heads/master@{#330834}

Powered by Google App Engine
This is Rietveld 408576698