Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 11570067: Created a bug for the 'cannot open display' issue and made it independend of display number (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index b864d414fe21e3fe05ef9778e37ae31c1cf3b58c..3ccc3eedab0547c5c78251519380f15fa38a5035 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -624,7 +624,9 @@ class BrowserCommandOutputImpl extends CommandOutputImpl {
// so we have to do this check first.
var stderrLines = new String.fromCharCodes(super.stderr).split("\n");
for (String line in stderrLines) {
- if (line.contains('Gtk-WARNING **: cannot open display: :99') ||
+ // TODO(kustermann,ricow): Issue: 7564
+ // This seems to happen quite frequently, we need to figure out why.
+ if (line.contains('Gtk-WARNING **: cannot open display') ||
line.contains('Failed to run command. return code=1')) {
// If we get the X server error, or DRT crashes with a core dump, retry
// the test.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698