Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 11570067: Created a bug for the 'cannot open display' issue and made it independend of display number (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 606 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 } 617 }
618 618
619 bool get _failedBecauseOfMissingXDisplay { 619 bool get _failedBecauseOfMissingXDisplay {
620 // Browser case: 620 // Browser case:
621 // If the browser test failed, it may have been because DumpRenderTree 621 // If the browser test failed, it may have been because DumpRenderTree
622 // and the virtual framebuffer X server didn't hook up, or DRT crashed with 622 // and the virtual framebuffer X server didn't hook up, or DRT crashed with
623 // a core dump. Sometimes DRT crashes after it has set the stdout to PASS, 623 // a core dump. Sometimes DRT crashes after it has set the stdout to PASS,
624 // so we have to do this check first. 624 // so we have to do this check first.
625 var stderrLines = new String.fromCharCodes(super.stderr).split("\n"); 625 var stderrLines = new String.fromCharCodes(super.stderr).split("\n");
626 for (String line in stderrLines) { 626 for (String line in stderrLines) {
627 if (line.contains('Gtk-WARNING **: cannot open display: :99') || 627 // TODO(kustermann,ricow): Issue: 7564
628 // This seems to happen quite frequently, we need to figure out why.
629 if (line.contains('Gtk-WARNING **: cannot open display') ||
628 line.contains('Failed to run command. return code=1')) { 630 line.contains('Failed to run command. return code=1')) {
629 // If we get the X server error, or DRT crashes with a core dump, retry 631 // If we get the X server error, or DRT crashes with a core dump, retry
630 // the test. 632 // the test.
631 if ((testCase as BrowserTestCase).numRetries > 0) { 633 if ((testCase as BrowserTestCase).numRetries > 0) {
632 requestRetry = true; 634 requestRetry = true;
633 } 635 }
634 print("Warning: Test failure because of missing XDisplay"); 636 print("Warning: Test failure because of missing XDisplay");
635 return true; 637 return true;
636 } 638 }
637 } 639 }
(...skipping 1098 matching lines...) Expand 10 before | Expand all | Expand 10 after
1736 // the developer doesn't waste his or her time trying to fix a bunch of 1738 // the developer doesn't waste his or her time trying to fix a bunch of
1737 // tests that appear to be broken but were actually just flakes that 1739 // tests that appear to be broken but were actually just flakes that
1738 // didn't get retried because there had already been one failure. 1740 // didn't get retried because there had already been one failure.
1739 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests; 1741 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
1740 new RunningProcess(test, allowRetry, this).start(); 1742 new RunningProcess(test, allowRetry, this).start();
1741 } 1743 }
1742 _numProcesses++; 1744 _numProcesses++;
1743 } 1745 }
1744 } 1746 }
1745 } 1747 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698