chrome/browser/prefs/pref_service_mock_builder.h - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_service_mock_builder.h

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/app_notify_channel_setup_unittest.cc ('K') | « chrome/browser/prefs/pref_service_builder.cc ('k') | chrome/browser/prefs/pref_service_mock_builder.cc » ('j') | chrome/browser/prefs/pref_service_simple.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/pref_service_mock_builder.h

diff --git a/chrome/browser/prefs/pref_service_mock_builder.h b/chrome/browser/prefs/pref_service_mock_builder.h

index 8b8aeabb0160513ab06d589e8d9b63d97d0b6758..4c82e4f6ea4941d85dc785678f1521c3c6e6b70e 100644

--- a/chrome/browser/prefs/pref_service_mock_builder.h

+++ b/chrome/browser/prefs/pref_service_mock_builder.h

@@ -13,7 +13,8 @@

class CommandLine;

class FilePath;

-class PrefService;

+class PrefServiceSimple;

+class PrefServiceSyncable;

namespace base {

class SequencedTaskRunner;

@@ -42,7 +43,8 @@ class PrefServiceMockBuilder : public PrefServiceBuilder {

// Creates a PrefService for testing, invalidating the entire

// builder configuration.

- virtual PrefService* Create() OVERRIDE;

+ PrefServiceSimple* CreateSimple();

+ PrefServiceSyncable* CreateSyncable();

private:

void ResetTestingState();