chrome/browser/extensions/app_notify_channel_setup_unittest.cc - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_notify_channel_setup_unittest.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_test.cc ('k') | chrome/browser/extensions/component_loader.h » ('j') | chrome/browser/prefs/pref_service_simple.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/app_notify_channel_setup_unittest.cc

diff --git a/chrome/browser/extensions/app_notify_channel_setup_unittest.cc b/chrome/browser/extensions/app_notify_channel_setup_unittest.cc

index bd5966301ac73ed74ee6e2179ec5fbe8235084af..2e13bc5a4cdbd725efc483e7bbd8d1434d2fea5a 100644

--- a/chrome/browser/extensions/app_notify_channel_setup_unittest.cc

+++ b/chrome/browser/extensions/app_notify_channel_setup_unittest.cc

@@ -182,9 +182,8 @@ class AppNotifyChannelSetupTest : public testing::Test {

virtual ~AppNotifyChannelSetupTest() {}

virtual void SetLoggedInUser(const std::string username) {

- TestingPrefService* prefs = profile_.GetTestingPrefService();

- prefs->SetUserPref(prefs::kGoogleServicesUsername,

- new StringValue(username));

+ StringValue value(username);

+ profile_.GetPrefs()->Set(prefs::kGoogleServicesUsername, value);

Mattias Nissler (ping if slow) 2012/12/21 13:09:31 Also, you could just use SetString() :)

Jói 2012/12/21 14:34:13 Done.

}

virtual AppNotifyChannelSetup* CreateInstance() {