chrome/browser/password_manager/password_store_factory.cc - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_factory.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/app_notify_channel_setup_unittest.cc ('K') | « chrome/browser/password_manager/password_store_factory.h ('k') | chrome/browser/password_manager/password_store_x.h » ('j') | chrome/browser/prefs/pref_service_simple.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_factory.cc

diff --git a/chrome/browser/password_manager/password_store_factory.cc b/chrome/browser/password_manager/password_store_factory.cc

index 70922f09ccffd8c361ef52a6422eb24f27bbda63..d2da9db8979b9d4a1ef8554ffee71da3a1706001 100644

--- a/chrome/browser/password_manager/password_store_factory.cc

+++ b/chrome/browser/password_manager/password_store_factory.cc

@@ -192,12 +192,12 @@ PasswordStoreFactory::BuildServiceInstanceFor(Profile* profile) const {

return ps;

}

-void PasswordStoreFactory::RegisterUserPrefs(PrefService* prefs) {

+void PasswordStoreFactory::RegisterUserPrefs(PrefServiceSyncable* prefs) {

#if !defined(OS_MACOSX) && !defined(OS_CHROMEOS) && !defined(OS_ANDROID) \

&& defined(OS_POSIX)

prefs->RegisterIntegerPref(prefs::kLocalProfileId,

kInvalidLocalProfileId,

- PrefService::UNSYNCABLE_PREF);

+ PrefServiceSyncable::UNSYNCABLE_PREF);

// Notice that the preprocessor conditions above are exactly those that will

// result in using PasswordStoreX in CreatePasswordStore() below.