chrome/browser/password_manager/password_manager.cc - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/app_notify_channel_setup_unittest.cc ('K') | « chrome/browser/password_manager/password_manager.h ('k') | chrome/browser/password_manager/password_manager_unittest.cc » ('j') | chrome/browser/prefs/pref_service_simple.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager.cc

diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc

index 9b0c2b2bde4a86298d35d21b1a93f89a483c5c5e..66c90d8ab2c71691369bdc1d4ac2929f15cc49a1 100644

--- a/chrome/browser/password_manager/password_manager.cc

+++ b/chrome/browser/password_manager/password_manager.cc

@@ -57,13 +57,13 @@ void ReportMetrics(bool password_manager_enabled) {

} // anonymous namespace

// static

-void PasswordManager::RegisterUserPrefs(PrefService* prefs) {

+void PasswordManager::RegisterUserPrefs(PrefServiceSyncable* prefs) {

prefs->RegisterBooleanPref(prefs::kPasswordManagerEnabled,

true,

- PrefService::SYNCABLE_PREF);

+ PrefServiceSyncable::SYNCABLE_PREF);

prefs->RegisterBooleanPref(prefs::kPasswordManagerAllowShowPasswords,

true,

- PrefService::UNSYNCABLE_PREF);

+ PrefServiceSyncable::UNSYNCABLE_PREF);

}

// static