Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/extensions/component_loader.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/component_loader.cc
diff --git a/chrome/browser/extensions/component_loader.cc b/chrome/browser/extensions/component_loader.cc
index 0adb9a099f7bbc74449bfd07575951d5a9480992..6fcf55a9c93def9c22729701564cf0ad92ff085a 100644
--- a/chrome/browser/extensions/component_loader.cc
+++ b/chrome/browser/extensions/component_loader.cc
@@ -69,12 +69,12 @@ ComponentLoader::ComponentExtensionInfo::ComponentExtensionInfo(
}
ComponentLoader::ComponentLoader(ExtensionServiceInterface* extension_service,
- PrefService* prefs,
- PrefService* local_state)
- : prefs_(prefs),
+ PrefServiceBase* profile_prefs,
+ PrefServiceBase* local_state)
+ : profile_prefs_(profile_prefs),
local_state_(local_state),
extension_service_(extension_service) {
- pref_change_registrar_.Init(prefs);
+ pref_change_registrar_.Init(profile_prefs);
// This pref is set by policy. We have to watch it for change because on
// ChromeOS, policy isn't loaded until after the browser process is started.
@@ -272,7 +272,7 @@ void ComponentLoader::AddOrReloadEnterpriseWebStore() {
Remove(path);
std::string enterprise_webstore_url =
- prefs_->GetString(prefs::kEnterpriseWebStoreURL);
+ profile_prefs_->GetString(prefs::kEnterpriseWebStoreURL);
// Load the extension only if the URL preference is set.
if (!enterprise_webstore_url.empty()) {
@@ -283,7 +283,8 @@ void ComponentLoader::AddOrReloadEnterpriseWebStore() {
// The manifest is missing some values that are provided by policy.
DictionaryValue* manifest = ParseManifest(manifest_contents);
if (manifest) {
- std::string name = prefs_->GetString(prefs::kEnterpriseWebStoreName);
+ std::string name =
+ profile_prefs_->GetString(prefs::kEnterpriseWebStoreName);
manifest->SetString("app.launch.web_url", enterprise_webstore_url);
manifest->SetString("name", name);
Add(manifest, path);
@@ -426,13 +427,13 @@ void ComponentLoader::UnloadComponent(ComponentExtensionInfo* component) {
}
// static
-void ComponentLoader::RegisterUserPrefs(PrefService* prefs) {
+void ComponentLoader::RegisterUserPrefs(PrefServiceSyncable* prefs) {
prefs->RegisterStringPref(prefs::kEnterpriseWebStoreURL,
std::string() /* default_value */,
- PrefService::UNSYNCABLE_PREF);
+ PrefServiceSyncable::UNSYNCABLE_PREF);
prefs->RegisterStringPref(prefs::kEnterpriseWebStoreName,
std::string() /* default_value */,
- PrefService::UNSYNCABLE_PREF);
+ PrefServiceSyncable::UNSYNCABLE_PREF);
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698