chrome/browser/download/chrome_download_manager_delegate.cc - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/download/chrome_download_manager_delegate_unittest.cc » ('j') | chrome/browser/extensions/app_notify_channel_setup_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/chrome_download_manager_delegate.cc

diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc

index dec52fc3853fec32e1b7fbfd15e1308c8bfdaf1a..488793ba6aefc5db30db210f328cc7e8a5f77a3b 100644

--- a/chrome/browser/download/chrome_download_manager_delegate.cc

+++ b/chrome/browser/download/chrome_download_manager_delegate.cc

@@ -483,7 +483,7 @@ void ChromeDownloadManagerDelegate::GetSaveDir(BrowserContext* browser_context,

FilePath* download_save_dir,

bool* skip_dir_check) {

Profile* profile = Profile::FromBrowserContext(browser_context);

- PrefService* prefs = profile->GetPrefs();

+ PrefServiceSyncable* prefs = profile->GetPrefs();

// Check whether the preference has the preferred directory for saving file.

// If not, initialize it with default directory.

@@ -493,7 +493,7 @@ void ChromeDownloadManagerDelegate::GetSaveDir(BrowserContext* browser_context,

prefs::kDownloadDefaultDirectory);

prefs->RegisterFilePathPref(prefs::kSaveFileDefaultDirectory,

default_save_path,

- PrefService::UNSYNCABLE_PREF);

+ PrefServiceSyncable::UNSYNCABLE_PREF);

}

// Get the directory from preference.