Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3246)

Unified Diff: chrome/browser/component_updater/recovery_component_installer.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/recovery_component_installer.cc
diff --git a/chrome/browser/component_updater/recovery_component_installer.cc b/chrome/browser/component_updater/recovery_component_installer.cc
index 1c2d61b3c02f5fc8a04ae83d3bdd506df0b7a68b..673a6cec2d4dd14cbdc9ba1a7d41d05854590338 100644
--- a/chrome/browser/component_updater/recovery_component_installer.cc
+++ b/chrome/browser/component_updater/recovery_component_installer.cc
@@ -60,8 +60,12 @@ class RecoveryComponentInstaller : public ComponentInstaller {
PrefService* prefs_;
};
-void RecoveryRegisterHelper(ComponentUpdateService* cus, PrefService* prefs) {
+void RecoveryRegisterHelper(ComponentUpdateService* cus,
+ PrefServiceSimple* prefs) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ // TODO(joi): Registrations for local state prefs shouldn't happen
+ // like this, they should be done via
+ // browser_prefs::RegisterLocalState.
prefs->RegisterStringPref(prefs::kRecoveryComponentVersion, "0.0.0.0");
Version version(prefs->GetString(prefs::kRecoveryComponentVersion));
if (!version.IsValid()) {
@@ -130,7 +134,7 @@ bool RecoveryComponentInstaller::Install(base::DictionaryValue* manifest,
}
void RegisterRecoveryComponent(ComponentUpdateService* cus,
- PrefService* prefs) {
+ PrefServiceSimple* prefs) {
#if !defined(OS_CHROMEOS)
// We delay execute the registration because we are not required in
// the critical path during browser startup.

Powered by Google App Engine
This is Rietveld 408576698