chrome/browser/chromeos/proxy_config_service_impl_unittest.cc - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl_unittest.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/proxy_config_service_impl.cc ('k') | chrome/browser/chromeos/settings/device_settings_cache.h » ('j') | chrome/browser/extensions/app_notify_channel_setup_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/proxy_config_service_impl_unittest.cc

diff --git a/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc b/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc

index e102e0462de6f82b4f9b6da8bdf15fecd32a9e06..9040c7719227234e6da9f8905b111cf118ca9365 100644

--- a/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc

+++ b/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc

@@ -235,7 +235,7 @@ class ProxyConfigServiceImplTestBase : public TESTBASE {

: ui_thread_(BrowserThread::UI, &loop_),

io_thread_(BrowserThread::IO, &loop_) {}

- virtual void Init(PrefService* pref_service) {

+ virtual void Init(PrefServiceSimple* pref_service) {

ASSERT_TRUE(pref_service);

DBusThreadManager::Initialize();

PrefProxyConfigTrackerImpl::RegisterPrefs(pref_service);

@@ -340,7 +340,7 @@ class ProxyConfigServiceImplTest

Init(&pref_service_);

}

- TestingPrefService pref_service_;

+ TestingPrefServiceSimple pref_service_;

};

TEST_F(ProxyConfigServiceImplTest, NetworkProxy) {