Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

Index: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
index 0c89013fe787819ac11d616d9e475dc8e8453c1b..4d3cc6600215aff75a3a00fbaba3585398216b77 100644
--- a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
+++ b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
@@ -279,7 +279,7 @@ class ProtocolHandlerRegistryTest : public testing::Test {
   FakeDelegate* delegate() const { return delegate_; }
   ProtocolHandlerRegistry* registry() { return registry_.get(); }
   TestingProfile* profile() const { return profile_.get(); }
-  PrefService* pref_service() const { return profile_->GetPrefs(); }
+  PrefServiceSyncable* pref_service() const { return profile_->GetPrefs(); }

[Mattias Nissler (ping if slow), 2012/12/19 19:50:22]

Is this accessor really necessary? It seems the code in SetUp() could do
without.

[Jói, 2012/12/20 16:30:31]

Added a TODO to investigate this.

   const ProtocolHandler& test_protocol_handler() const {
     return test_protocol_handler_;
   }
@@ -318,11 +318,11 @@ class ProtocolHandlerRegistryTest : public testing::Test {
 
   virtual void SetUp() {
     profile_.reset(new TestingProfile());
-    profile_->SetPrefService(new TestingPrefService());
+    profile_->SetPrefService(new TestingPrefServiceSyncable());

[Mattias Nissler (ping if slow), 2012/12/19 19:50:22]

This shouldn't be necessary, TestingProfile already has a PrefService.

[Jói, 2012/12/20 16:30:31]

As above, added TODO to investigate.

     SetUpRegistry(true);
     test_protocol_handler_ =
         CreateProtocolHandler("test", GURL("http://test.com/%s"), "Test");
-    ProtocolHandlerRegistry::RegisterPrefs(pref_service());
+    ProtocolHandlerRegistry::RegisterUserPrefs(pref_service());

[Mattias Nissler (ping if slow), 2012/12/19 19:50:22]

This should be removed if you remove line 321.

[Jói, 2012/12/20 16:30:31]

Ditto.

   }
 
   virtual void TearDown() {