Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

chrome/browser/debugger/devtools_window.cc

Index: chrome/browser/debugger/devtools_window.cc
diff --git a/chrome/browser/debugger/devtools_window.cc b/chrome/browser/debugger/devtools_window.cc
index 3001b6bfd1cfa9cde02df771fb51cb6e17130445..723f644163d590dfbdfab246e0137561dbb51b27 100644
--- a/chrome/browser/debugger/devtools_window.cc
+++ b/chrome/browser/debugger/devtools_window.cc
@@ -87,15 +87,15 @@ const int kMinDevToolsWidth = 150;
 const int kMinContentsSize = 50;
 
 // static
-void DevToolsWindow::RegisterUserPrefs(PrefService* prefs) {
+void DevToolsWindow::RegisterUserPrefs(PrefServiceSyncable* prefs) {
   prefs->RegisterBooleanPref(prefs::kDevToolsOpenDocked,
                              true,
-                             PrefService::UNSYNCABLE_PREF);
+                             PrefServiceSyncable::UNSYNCABLE_PREF);
   prefs->RegisterStringPref(prefs::kDevToolsDockSide,
                             kDockSideBottom,
-                            PrefService::UNSYNCABLE_PREF);
+                            PrefServiceSyncable::UNSYNCABLE_PREF);
   prefs->RegisterDictionaryPref(prefs::kDevToolsEditedFiles,
-                                PrefService::UNSYNCABLE_PREF);
+                                PrefServiceSyncable::UNSYNCABLE_PREF);
 }
 
 // static
@@ -376,9 +376,10 @@ void DevToolsWindow::CreateDevToolsBrowser() {
   wp_key.append("_");
   wp_key.append(kDevToolsApp);
 
-  PrefService* prefs = profile_->GetPrefs();
+  PrefServiceSyncable* prefs = profile_->GetPrefs();
   if (!prefs->FindPreference(wp_key.c_str())) {
-    prefs->RegisterDictionaryPref(wp_key.c_str(), PrefService::UNSYNCABLE_PREF);
+    prefs->RegisterDictionaryPref(wp_key.c_str(),
+                                  PrefServiceSyncable::UNSYNCABLE_PREF);

[Mattias Nissler (ping if slow), 2012/12/19 19:50:22]

random note: This should go through browser_prefs::RegisterUserPrefs

[Jói, 2012/12/20 16:30:31]

Added a TODO to fix.

   }
 
   const DictionaryValue* wp_pref = prefs->GetDictionary(wp_key.c_str());