Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1156993018: GlobalDictionary now stores PropertyDetails in PropertyCells. (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

GlobalDictionary now stores PropertyDetails in PropertyCells. BUG= Committed: https://crrev.com/1f24c38bde400ee6b29b20dce44b8c7f53fe22be Cr-Commit-Position: refs/heads/master@{#28752}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -53 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 7 chunks +50 lines, -11 lines 0 comments Download
M src/objects.cc View 1 8 chunks +21 lines, -19 lines 0 comments Download
M src/objects-inl.h View 1 4 chunks +55 lines, -6 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Igor Sheludko
PTAL, step 4
5 years, 6 months ago (2015-06-01 14:12:41 UTC) #6
Jakob Kummerow
LGTM with a question. https://codereview.chromium.org/1156993018/diff/80001/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/1156993018/diff/80001/src/objects-inl.h#newcode7243 src/objects-inl.h:7243: CHECK(raw_value->IsPropertyCell()); Do we need to ...
5 years, 6 months ago (2015-06-02 07:18:09 UTC) #7
Igor Sheludko
https://codereview.chromium.org/1156993018/diff/80001/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/1156993018/diff/80001/src/objects-inl.h#newcode7243 src/objects-inl.h:7243: CHECK(raw_value->IsPropertyCell()); On 2015/06/02 07:18:09, Jakob wrote: > Do we ...
5 years, 6 months ago (2015-06-02 09:57:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156993018/100001
5 years, 6 months ago (2015-06-02 09:57:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 6 months ago (2015-06-02 10:29:18 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 10:29:32 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1f24c38bde400ee6b29b20dce44b8c7f53fe22be
Cr-Commit-Position: refs/heads/master@{#28752}

Powered by Google App Engine
This is Rietveld 408576698