src/lookup-inl.h - Issue 1156993018: GlobalDictionary now stores PropertyDetails in PropertyCells.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup-inl.h

Issue 1156993018: GlobalDictionary now stores PropertyDetails in PropertyCells. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup-inl.h

diff --git a/src/lookup-inl.h b/src/lookup-inl.h

index d88f4e47f70dd6bfef316c7123dd9cb0e699f612..ff704aa06ef7e69262faf0bf503cb26c3614e75d 100644

--- a/src/lookup-inl.h

+++ b/src/lookup-inl.h

@@ -72,7 +72,7 @@ LookupIterator::State LookupIterator::LookupInHolder(Map* const map,

DCHECK(dict->ValueAt(number_)->IsPropertyCell());

PropertyCell* cell = PropertyCell::cast(dict->ValueAt(number_));

if (cell->value()->IsTheHole()) return NOT_FOUND;

- property_details_ = dict->DetailsAt(number_);

+ property_details_ = cell->property_details();

} else if (map->is_dictionary_map()) {

NameDictionary* dict = JSObject::cast(holder)->property_dictionary();

int number = dict->FindEntry(name_);

« no previous file with comments | « src/heap/heap.cc ('k') | src/objects.h » ('j') | no next file with comments »