Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: Source/core/frame/Settings.in

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: cleaned up volume / mute hiding logic. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/Settings.in
diff --git a/Source/core/frame/Settings.in b/Source/core/frame/Settings.in
index 08bbb47efa225b294d03f0ccb52db6c1ae11e4ba..45ecaf163171d8c88c0c875be75126f208f632a3 100644
--- a/Source/core/frame/Settings.in
+++ b/Source/core/frame/Settings.in
@@ -351,3 +351,19 @@ textTrackTextSize type=String
lowPriorityIframes initial=false
reportWheelOverscroll initial=false
+
+# Do we want to try to save screen real estate in the media player by hiding
+# the volume slider? It is not guaranteed that the volume slider will always
+# be hidden if this is set.
+preferHiddenVolumeSlider initial=false
philipj_slow 2015/07/10 14:51:58 Could these be collapsed into a single setting, af
liberato (no reviews please) 2015/07/10 15:32:19 i did that originally, but separated them for reas
+
+# Do we want to try to save screen real estate in the media player by hiding
+# the mute button when possible?
+preferHiddenMuteButton initial=false
+
+# The media player will only hide volume / mute if the corresponding
+# prefer* setting is on, and if it's using the new UI. This setting lets
+# us override the second part, and enable it for the previous UI as well.
+# TODO(liberato): remove this setting once the old UI is removed. It
+# facilitates testing without worrying about which UI is enabled.
+forceAllowHiddenAudioElements initial=false
philipj_slow 2015/07/10 14:21:35 Setting that are for testing only can be put in So
liberato (no reviews please) 2015/07/10 15:32:19 that's cool! I moved it to Internals.idl, since t

Powered by Google App Engine
This is Rietveld 408576698