Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Defines properties which are available on the Settings object. | 1 # Defines properties which are available on the Settings object. |
| 2 # | 2 # |
| 3 # Please think carefully before adding a new Setting. Some questions to | 3 # Please think carefully before adding a new Setting. Some questions to |
| 4 # consider are: | 4 # consider are: |
| 5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things | 5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things |
| 6 # which we support either values of at runtime. Features are set at renderer | 6 # which we support either values of at runtime. Features are set at renderer |
| 7 # process startup and are never changed. Features also tend to be set to a | 7 # process startup and are never changed. Features also tend to be set to a |
| 8 # value based on the platform or the stability of the code in question, where | 8 # value based on the platform or the stability of the code in question, where |
| 9 # as settings both codepaths need to be stable. | 9 # as settings both codepaths need to be stable. |
| 10 # - How will you ensure test coverage of all relevant values of your setting? | 10 # - How will you ensure test coverage of all relevant values of your setting? |
| (...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 344 textTrackFontFamily type=String | 344 textTrackFontFamily type=String |
| 345 textTrackFontStyle type=String | 345 textTrackFontStyle type=String |
| 346 textTrackFontVariant type=String | 346 textTrackFontVariant type=String |
| 347 textTrackTextColor type=String | 347 textTrackTextColor type=String |
| 348 textTrackTextShadow type=String | 348 textTrackTextShadow type=String |
| 349 textTrackTextSize type=String | 349 textTrackTextSize type=String |
| 350 | 350 |
| 351 lowPriorityIframes initial=false | 351 lowPriorityIframes initial=false |
| 352 | 352 |
| 353 reportWheelOverscroll initial=false | 353 reportWheelOverscroll initial=false |
| 354 | |
| 355 # Do we want to try to save screen real estate in the media player by hiding | |
| 356 # the volume slider? It is not guaranteed that the volume slider will always | |
| 357 # be hidden if this is set. | |
| 358 preferHiddenVolumeSlider initial=false | |
|
philipj_slow
2015/07/10 14:51:58
Could these be collapsed into a single setting, af
liberato (no reviews please)
2015/07/10 15:32:19
i did that originally, but separated them for reas
| |
| 359 | |
| 360 # Do we want to try to save screen real estate in the media player by hiding | |
| 361 # the mute button when possible? | |
| 362 preferHiddenMuteButton initial=false | |
| 363 | |
| 364 # The media player will only hide volume / mute if the corresponding | |
| 365 # prefer* setting is on, and if it's using the new UI. This setting lets | |
| 366 # us override the second part, and enable it for the previous UI as well. | |
| 367 # TODO(liberato): remove this setting once the old UI is removed. It | |
| 368 # facilitates testing without worrying about which UI is enabled. | |
| 369 forceAllowHiddenAudioElements initial=false | |
|
philipj_slow
2015/07/10 14:21:35
Setting that are for testing only can be put in So
liberato (no reviews please)
2015/07/10 15:32:19
that's cool! I moved it to Internals.idl, since t
| |
| OLD | NEW |