LayoutTests/media/track/track-cue-rendering-after-controls-added.html - Issue 1156993013: New media playback UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/track/track-cue-rendering-after-controls-added.html

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: ...because i compiled release. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/media/controls-cast-button.html ('k') | LayoutTests/media/track/track-cue-rendering-wider-than-controls.html » ('j') | LayoutTests/media/video-controls-mouse-events-captured.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/track/track-cue-rendering-after-controls-added.html

diff --git a/LayoutTests/media/track/track-cue-rendering-after-controls-added.html b/LayoutTests/media/track/track-cue-rendering-after-controls-added.html

index c465d0d2809465dc0519f692159ed853a2cf4fd9..4ca57d079c02113e39ee0f5e26f98a287bd16b84 100644

--- a/LayoutTests/media/track/track-cue-rendering-after-controls-added.html

+++ b/LayoutTests/media/track/track-cue-rendering-after-controls-added.html

@@ -22,9 +22,14 @@ track.mode = "showing";

video.onloadeddata = function() {

testRunner.layoutAndPaintAsyncThen(function() {

- // Add the controls. The cue should move to avoid overlap.

+ // Add the controls. The cue should move to avoid overlap. Defer this

+ // until the controls resize.

video.controls = true;

- testRunner.notifyDone();

+ // Wait for the relayout event to happen.

+ setTimeout(function()

philipj_slow 2015/08/05 08:41:05 This is likely to be flaky. https://docs.google.co

liberato (no reviews please) 2015/08/05 16:36:40 thanks! that's a great reference.

+ {

+ testRunner.notifyDone();

+ }, 0);

});

};

</script>