New media playback UI.

LayoutTests/TestExpectations

Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index c1c2d5adce379a4fe36db4a0bba30db271d52549..d3eb216e3d8afe0eaf013e01bc1c0b6fa99b86c7 100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1501,6 +1501,8 @@ crbug.com/491006 http/tests/security/cross-origin-access-over-property-descripto
 
 crbug.com/493815 inspector/elements/iframe-load-event.html [ Pass Failure ]
 
+crbug.com/446350 compositing/geometry/video-fixed-scrolling.html [ NeedsRebaseline ]

[philipj_slow, 2015/08/05 08:41:05]

So I ran this test and the failure is:

---
/home/philip/src/chromium/src/webkit/Debug/layout-test-results/compositing/geometry/video-fixed-scrolling-expected.txt
+++
/home/philip/src/chromium/src/webkit/Debug/layout-test-results/compositing/geometry/video-fixed-scrolling-actual.txt
@@ -8,13 +8,15 @@
       LayoutBlockFlow {P} at (0,401) size 769x20
         LayoutText {#text} at (0,0) size 425x19
           text run at (0,0) width 425: "The blue bar should be in front of the
video, and at the top of the page."
+      LayoutBlockFlow (anonymous) at (0,437) size 769x0
+        LayoutText {#text} at (0,0) size 0x0
 layer at (8,88) size 400x300
   LayoutVideo {VIDEO} at (0,80) size 400x300
 layer at (8,88) size 400x300
   LayoutFlexibleBox (relative positioned) {DIV} at (0,0) size 400x300
-    LayoutBlockFlow {DIV} at (0,265) size 400x35
-layer at (8,88) size 400x265
-  LayoutFlexibleBox (relative positioned) {DIV} at (0,0) size 400x265
+    LayoutBlockFlow {DIV} at (0,252) size 400x48
+layer at (8,88) size 400x242
+  LayoutFlexibleBox (relative positioned) {DIV} at (0,0) size 400x242
 layer at (0,50) size 500x60
   LayoutBlockFlow (positioned) {DIV} at (0,0) size 500x60 [bgcolor=#0000FFCC]
 scrolled to 0,50

What is this change, and why is it happening before the flag is flipped?

[liberato (no reviews please), 2015/08/05 16:36:40]

hrm, this is not what i get.  the LayoutBlockFlow with height 48 looks like the
controls were still enabled when this test is run.  when i run them off, i see
only the first two added lines in the diff (LayoutBlockFlow 769x0 and LayoutText
0x0).

The x0 lines show up with the call to clientWidth() at the end of
MediaControls::reset() to set m_panelWidth.  I'll make it conditional on the
flag, then the test passes.

i have absolutely no idea why asking for the width causes the render tree to
change.  i added a comment in reset() that describes it.

+
 crbug.com/493939 [ XP ] http/tests/security/cross-origin-css.html [ Timeout Pass ]
 
 crbug.com/321237 [ Mac ] fast/text/international/bidi-neutral-run.html [ Pass Crash NeedsManualRebaseline ]