Source/core/css/mediaControlsAndroidNew.css - Issue 1156993013: New media playback UI.

Side by Side Diff: Source/core/css/mediaControlsAndroidNew.css

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: manual rebaseline. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /**/	1 /*

	2 * Copyright (C) 2015 Google Inc.

	3 * Copyright (C) 2009 Apple Inc. All rights reserved.
	philipj_slow 2015/07/08 10:31:52 I would keep the copyright header from which this I would keep the copyright header from which this was copied, or use the new smaller one if it wasn't copied. Changing years and adding lines over time is tedious :) liberato (no reviews please) 2015/07/09 12:10:56 i'll update this with the de-crufting to match med Show quoted text On 2015/07/08 10:31:52, philipj wrote: > I would keep the copyright header from which this was copied, or use the new > smaller one if it wasn't copied. Changing years and adding lines over time is > tedious :) i'll update this with the de-crufting to match mediaControlsAndroid.css, from which it came. liberato (no reviews please) 2015/07/14 22:10:36 copied from mediaControlsAndroid.css . Show quoted text On 2015/07/09 12:10:56, liberato wrote: > On 2015/07/08 10:31:52, philipj wrote: > > I would keep the copyright header from which this was copied, or use the new > > smaller one if it wasn't copied. Changing years and adding lines over time is > > tedious :) > > i'll update this with the de-crufting to match mediaControlsAndroid.css, from > which it came. copied from mediaControlsAndroid.css .
	4 * Copyright (C) 2009 Google Inc.

	5 *

	6 * Redistribution and use in source and binary forms, with or without

	7 * modification, are permitted provided that the following conditions

	8 * are met:

	9 * 1. Redistributions of source code must retain the above copyright

	10 * notice, this list of conditions and the following disclaimer.

	11 * 2. Redistributions in binary form must reproduce the above copyright

	12 * notice, this list of conditions and the following disclaimer in the

	13 * documentation and/or other materials provided with the distribution.

	14 *

	15 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY

	16 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE

	17 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR

	18 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR

	19 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,

	20 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,

	21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY

	22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

	23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

	24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

	25 */

	26

	27 /* Media controls for Chromium on Android */

	28

	29 /* WARNING: This css file can only style <audio> and <video> elements */

	30

	31 audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-bu tton {
	philipj_slow 2015/07/08 10:31:51 This is contrary to https://codereview.chromium.or This is contrary to https://codereview.chromium.org/1045103002/ I happen to agree that and we have a patch in Opera for Android to get rid of the mute button, but was this discussed internally? liberato (no reviews please) 2015/07/09 12:10:56 it was, but i was unaware of this bug. i'll follo Show quoted text On 2015/07/08 10:31:51, philipj wrote: > This is contrary to https://codereview.chromium.org/1045103002/ > > I happen to agree that and we have a patch in Opera for Android to get rid of > the mute button, but was this discussed internally? it was, but i was unaware of this bug. i'll follow up. maybe we should show the unmute button if it's muted. that's what the most recent CL does. i also added a test to be sure that muted media shows an unmute button. how do you handle this case in opera?
	32 display: none;

	33 }

OLD	NEW

« Source/core/css/CSSDefaultStyleSheets.cpp ('K') | « Source/core/css/CSSDefaultStyleSheets.cpp ('k') | Source/core/css/mediaControlsNew.css » ('j') | Source/core/css/mediaControlsNew.css » ('J')