Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1045103002: Restore Mute button for Android media element. (Closed)

Created:
5 years, 8 months ago by Tima Vaisburd
Modified:
5 years, 8 months ago
Reviewers:
qinmin, timav, philipj_slow
CC:
blink-reviews, nessy, blink-reviews-css, philipj_slow, gasubic, ed+blinkwatch_opera.com, eric.carlson_apple.com, fs, feature-media-reviews_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, vcarbune.chromium, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Restore Mute button for Android media element. There are web sites that start videos muted by default. We show the MuteUnmute button to let the user manually unmute the media clip in the same way it works on desktop. BUG=467252 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/core/css/mediaControlsAndroid.css View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
timav
Please review.
5 years, 8 months ago (2015-03-30 21:33:21 UTC) #2
qinmin
lgtm
5 years, 8 months ago (2015-03-30 21:44:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045103002/1
5 years, 8 months ago (2015-03-30 23:22:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/30040)
5 years, 8 months ago (2015-03-30 23:54:51 UTC) #7
timav
Philip, could you, please, review this change? Thanks much.
5 years, 8 months ago (2015-03-31 00:24:39 UTC) #9
philipj_slow
lgtm
5 years, 8 months ago (2015-03-31 05:46:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045103002/1
5 years, 8 months ago (2015-03-31 05:46:33 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 05:50:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192803

Powered by Google App Engine
This is Rietveld 408576698