Issue 115693012: mac: Fix a history swiper bug with magic mouse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115693012: mac: Fix a history swiper bug with magic mouse. (Closed)

Created:
6 years, 11 months ago by erikchen

Modified:
6 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

mac: Fix a history swiper bug with magic mouse. Canceling a history swipe with the magic mouse would fail to hide the swipe arrow. Previously, the arrow was dismissed in `dealloc`, and I moved the animation to `dismiss` in a previous change (107343008). Unfortunately, the logic for magic mouse history swiping was failing to call `dismiss` if the history swipe was cancelled. BUG=330312 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243417

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/115693012/1

6 years, 11 months ago (2014-01-07 19:18:27 UTC) #3

Message was sent while issue was closed.

Change committed as 243417

Expand Messages | Collapse Messages