Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

Issue 115693012: mac: Fix a history swiper bug with magic mouse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
index f37cc6f74fc9fd5c02e3ba72cdcad566fe08dfd4..9729a1db1106999e561e1bdd12b6b8e8717138f1 100644
--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
@@ -379,8 +379,6 @@ static BOOL forceMagicMouse = NO;
progress = MAX(0.0, progress);
progress = MIN(1.0, progress);
[historyOverlay setProgress:progress finished:finished];
- if (ended)
- [historyOverlay dismiss];
// |gestureAmount| obeys -[NSEvent isDirectionInvertedFromDevice]
// automatically.
@@ -393,8 +391,10 @@ static BOOL forceMagicMouse = NO;
chrome::GoBack(browser, CURRENT_TAB);
}
- if (isComplete)
+ if (isComplete) {
+ [historyOverlay dismiss];
[historyOverlay release];
+ }
}];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698