Issue 1156763003: Revert of Unicode Variation Selectors support in collectCandidateRuns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156763003: Revert of Unicode Variation Selectors support in collectCandidateRuns (Closed)

Created:
5 years, 6 months ago by dmurph

Modified:
5 years, 6 months ago

Reviewers:
Dominik Röttsches, Kunihiko Sakamoto, kojii, eae, bashi

CC:
blink-reviews, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Unicode Variation Selectors support in collectCandidateRuns (patchset #4 id:60001 of https://codereview.chromium.org/1144033004/) Reason for revert: Causing failures, tracking here: https://code.google.com/p/chromium/issues/detail?id=493512 Original issue's description: > Unicode Variation Selectors support in collectCandidateRuns > > This patch supports Unicode Variation Selectors in collectCandidateRuns. > > This change alone does not fix the SVS/IVS bug crbug.com/383580. It has > to wait for another change to read CMAP 14 to get the correct glyphs > for SVS/IVS. > > BUG=383580 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196095 TBR=eae@chromium.org,dominik.rottsches@intel.com,bashi@chromium.org,ksakamoto@chromium.org,kojii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=383580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196111

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -38 lines)			Patch
M	Source/platform/fonts/Character.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/platform/fonts/shaping/HarfBuzzShaper.cpp	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp	View	1 chunk	+0 lines, -26 lines	0 comments	Download

Total messages: 3 (0 generated)

dmurph

Created Revert of Unicode Variation Selectors support in collectCandidateRuns

5 years, 6 months ago (2015-05-29 02:16:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156763003/1

5 years, 6 months ago (2015-05-29 02:17:16 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-05-29 02:17:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196111