Source/platform/fonts/shaping/HarfBuzzShaper.cpp - Issue 1156763003: Revert of Unicode Variation Selectors support in collectCandidateRuns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 1156763003: Revert of Unicode Variation Selectors support in collectCandidateRuns (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/shaping/HarfBuzzShaper.cpp

diff --git a/Source/platform/fonts/shaping/HarfBuzzShaper.cpp b/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

index 64f31044708cba9bb1d2af23a293126787b3a5be..44fcb3245b14168d38ef1e73f4016025a5fbcc78 100644

--- a/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

+++ b/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

@@ -579,10 +579,9 @@

if (Character::treatAsZeroWidthSpace(character))

continue;

if ((U_GET_GC_MASK(character) & U_GC_M_MASK)

- && (Character::isUnicodeVariationSelector(character)

- || currentFontData->canRenderCombiningCharacterSequence(

- currentCharacterPosition,

- iterator.glyphEnd() - currentCharacterPosition)))

+ && currentFontData->canRenderCombiningCharacterSequence(

+ currentCharacterPosition,

+ iterator.glyphEnd() - currentCharacterPosition))

continue;

nextFontData = font->glyphDataForCharacter(character, false, isSpaceNormalize).fontData;

« no previous file with comments | « Source/platform/fonts/Character.h ('k') | Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp » ('j') | no next file with comments »