Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1156663006: Add missing comma to third_party.gyp (Closed)

Created:
5 years, 7 months ago by bungeman-chromium
Modified:
5 years, 6 months ago
Reviewers:
Tom Sepez, brucedawson
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing comma to third_party.gyp A reference to nonstd_unique_ptr.h was added with https://codereview.chromium.org/1091283002 but a comma is missing after it. This causes this string to be concatenated with the next, leading to broken sources. This went unnoticed by the build due to the fact that the affected sources are both headers, but they should be properly separated. R=brucedawson@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8e1b60824d079546c8cc3f0e3d9fa0ea9fa980fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/third_party.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
bungeman-chromium
5 years, 7 months ago (2015-05-27 20:50:39 UTC) #3
brucedawson
lgtm Thanks for catching this. I CCed Tom to make sure he knows also. It ...
5 years, 6 months ago (2015-06-01 18:03:08 UTC) #4
Tom Sepez
Yeah, I can't type. LGTM.
5 years, 6 months ago (2015-06-01 18:06:43 UTC) #5
bungeman-chromium
On 2015/06/01 18:06:43, Tom Sepez wrote: > Yeah, I can't type. LGTM. It looks like ...
5 years, 6 months ago (2015-06-01 18:24:03 UTC) #6
brucedawson
I'll land it, and merge to the other branch.
5 years, 6 months ago (2015-06-01 21:42:35 UTC) #7
brucedawson
Committed patchset #1 (id:1) manually as 8e1b60824d079546c8cc3f0e3d9fa0ea9fa980fa (presubmit successful).
5 years, 6 months ago (2015-06-01 21:44:58 UTC) #8
Tom Sepez
5 years, 6 months ago (2015-06-01 23:26:53 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698