Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Issue 1091283002: Add nonstd::unique_ptr as a workaround until std::unique_ptr is allowed. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add nonstd::unique_ptr as a workaround until std::unique_ptr is allowed. This is a copy of breakpad's standalone scoped_ptr, which has been renamed to nonstd::unique_ptr, and from which more complicated classes have been removed. The reset() method has also been tweaked to more closely match c++11, and an implicit conversion to bool has been added. BUG=https://code.google.com/p/pdfium/issues/detail?id=55 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/29bc87d102b9e36c1e15385756c9fa9a214f3503

Patch Set 1 #

Patch Set 2 : Fix header comment. #

Patch Set 3 : Remove more irrelevant comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -0 lines) Patch
M third_party/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/base/nonstd_unique_ptr.h View 1 2 1 chunk +180 lines, -0 lines 0 comments Download
M third_party/third_party.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, I can't take it, can't take it no more ...
5 years, 8 months ago (2015-04-17 16:31:03 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-17 19:54:38 UTC) #3
Tom Sepez
5 years, 8 months ago (2015-04-17 19:55:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
29bc87d102b9e36c1e15385756c9fa9a214f3503 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698