Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(50)

Issue 1156663004: Test for cancelling PDF modal dialogs. (Closed)

Created:
4 years, 5 months ago by wjmaclean
Modified:
4 years, 5 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test for cancelling PDF modal dialogs. This test verifies that, when navigating to an interstitial page from a PDF that is currently displaying a modal dialog, that the dialog is cancelled. This test is expected to fail without https://codereview.chromium.org/1150843002/. BUG=482380

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use separate PDF test file, add comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/test/data/pdf/alert_dialog.pdf View 1 Binary file 0 comments Download

Messages

Total messages: 8 (1 generated)
wjmaclean
Please take a look and see if this seems sane. If the test seems reasonable, ...
4 years, 5 months ago (2015-05-22 21:36:29 UTC) #2
Charlie Reis
On 2015/05/22 21:36:29, wjmaclean wrote: > Please take a look and see if this seems ...
4 years, 5 months ago (2015-05-22 21:56:56 UTC) #3
Fady Samuel
On 2015/05/22 21:56:56, Charlie Reis wrote: > On 2015/05/22 21:36:29, wjmaclean wrote: > > Please ...
4 years, 5 months ago (2015-05-22 21:58:32 UTC) #4
Charlie Reis
Great. And I've confirmed that the test fails without my fix and passes with it. ...
4 years, 5 months ago (2015-05-22 22:36:03 UTC) #5
wjmaclean
Here's the revised test with the separate, simpler PDF file. Let me know if you ...
4 years, 5 months ago (2015-05-25 17:45:43 UTC) #6
Charlie Reis
Thanks! I've added it to https://codereview.chromium.org/1150843002/, so feel free to close this CL.
4 years, 5 months ago (2015-05-26 21:29:26 UTC) #7
wjmaclean
4 years, 5 months ago (2015-05-27 12:28:56 UTC) #8
On 2015/05/26 21:29:26, Charlie Reis wrote:
> Thanks!  I've added it to https://codereview.chromium.org/1150843002/, so feel
> free to close this CL.

Closing :-)

Powered by Google App Engine
This is Rietveld 408576698