runtime/vm/constants_ia32.h - Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constants_ia32.h

Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/constants_ia32.h

diff --git a/runtime/vm/constants_ia32.h b/runtime/vm/constants_ia32.h

index d609b8a1d5feb5089f74cc82add6a9bfc6d28665..f1edc353f10136ef3e4d7ac8258f40a1bd757bf4 100644

--- a/runtime/vm/constants_ia32.h

+++ b/runtime/vm/constants_ia32.h

@@ -68,6 +68,7 @@ const Register SPREG = ESP; // Stack pointer register.

const Register FPREG = EBP; // Frame pointer register.

const Register ICREG = ECX; // IC data register.

const Register ARGS_DESC_REG = EDX; // Arguments descriptor register.

+const Register THR = ESI; // Caches current thread in generated code.

// Exception object is passed in this register to the catch handlers when an

// exception is thrown.

« no previous file with comments | « runtime/vm/constants_arm64.h ('k') | runtime/vm/constants_mips.h » ('j') | runtime/vm/flow_graph_compiler.cc » ('J')