Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: runtime/vm/assembler_x64_test.cc

Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_x64_test.cc
diff --git a/runtime/vm/assembler_x64_test.cc b/runtime/vm/assembler_x64_test.cc
index 9989e3b1830351a95b7452132bdf0ec33f69709c..a10b52eeca8b1f11163cd174ad3a59a8479ac5bd 100644
--- a/runtime/vm/assembler_x64_test.cc
+++ b/runtime/vm/assembler_x64_test.cc
@@ -3308,6 +3308,8 @@ ASSEMBLER_TEST_RUN(SquareRootDouble, test) {
ASSEMBLER_TEST_GENERATE(StoreIntoObject, assembler) {
__ pushq(PP); // Save caller's pool pointer and load a new one here.
__ LoadPoolPointer(PP);
+ __ pushq(THR);
+ __ movq(THR, CallingConventions::kArg4Reg);
__ pushq(CTX);
__ movq(CTX, CallingConventions::kArg1Reg);
__ StoreIntoObject(CallingConventions::kArg3Reg,
@@ -3315,6 +3317,7 @@ ASSEMBLER_TEST_GENERATE(StoreIntoObject, assembler) {
GrowableObjectArray::data_offset()),
CallingConventions::kArg2Reg);
__ popq(CTX);
+ __ popq(THR);
__ popq(PP); // Restore caller's pool pointer.
__ ret();
}

Powered by Google App Engine
This is Rietveld 408576698