Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: net/http/http_server_properties_impl.cc

Issue 1156563004: Convert bare pointer to scoped_ptr in net/http (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_server_properties_impl.cc
diff --git a/net/http/http_server_properties_impl.cc b/net/http/http_server_properties_impl.cc
index bbf30c8b2f31f330611d66199ee191fa77816568..3af48a53e95446b5027d20569ac570668cd3cfba 100644
--- a/net/http/http_server_properties_impl.cc
+++ b/net/http/http_server_properties_impl.cc
@@ -397,7 +397,7 @@ const AlternativeServiceMap& HttpServerPropertiesImpl::alternative_service_map()
base::Value* HttpServerPropertiesImpl::GetAlternativeServiceInfoAsValue()
eroman 2015/05/29 22:13:06 This change is fine, but the more useful change is
const {
- base::ListValue* dict_list = new base::ListValue();
+ scoped_ptr<base::ListValue> dict_list(new base::ListValue());
for (const auto& alternative_service_map_item : alternative_service_map_) {
const HostPortPair& host_port_pair = alternative_service_map_item.first;
const AlternativeServiceInfo& alternative_service_info =
@@ -417,7 +417,7 @@ base::Value* HttpServerPropertiesImpl::GetAlternativeServiceInfoAsValue()
dict->SetString("alternative_service", alternative_service_string);
dict_list->Append(dict.Pass());
}
- return dict_list;
+ return dict_list.release();
}
const SettingsMap& HttpServerPropertiesImpl::GetSpdySettings(
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698