Convert bare pointer to scoped_ptr in net/http

net/http/http_server_properties_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_server_properties_impl.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 377 matching lines @@
   //     service can be in the mapping.
   //  2. Remove the rest of this method as it will be moot.
   broken_alternative_services_.erase(alternative_service);
 }
 
 const AlternativeServiceMap& HttpServerPropertiesImpl::alternative_service_map()
     const {
   return alternative_service_map_;
 }
 
 base::Value* HttpServerPropertiesImpl::GetAlternativeServiceInfoAsValue()

[eroman, 2015/05/29 22:13:06]

This change is fine, but the more useful change is to also make this function
return as scoped_ptr<base::Value> and then fix the callers too.

     const {
-  base::ListValue* dict_list = new base::ListValue();
+  scoped_ptr<base::ListValue> dict_list(new base::ListValue());
   for (const auto& alternative_service_map_item : alternative_service_map_) {
     const HostPortPair& host_port_pair = alternative_service_map_item.first;
     const AlternativeServiceInfo& alternative_service_info =
         alternative_service_map_item.second;
     std::string alternative_service_string(alternative_service_info.ToString());
     AlternativeService alternative_service(
         alternative_service_info.alternative_service);
     if (alternative_service.host.empty()) {
       alternative_service.host = host_port_pair.host();
     }
     if (IsAlternativeServiceBroken(alternative_service)) {
       alternative_service_string.append(" (broken)");
     }
 
     scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
     dict->SetString("host_port_pair", host_port_pair.ToString());
     dict->SetString("alternative_service", alternative_service_string);
     dict_list->Append(dict.Pass());
   }
-  return dict_list;
+  return dict_list.release();
 }
 
 const SettingsMap& HttpServerPropertiesImpl::GetSpdySettings(
     const HostPortPair& host_port_pair) {
   SpdySettingsMap::iterator it = spdy_settings_map_.Get(host_port_pair);
   if (it == spdy_settings_map_.end()) {
     CR_DEFINE_STATIC_LOCAL(SettingsMap, kEmptySettingsMap, ());
     return kEmptySettingsMap;
   }
   return it->second;
@@ skipping 163 matching lines @@
   base::TimeDelta delay = when > now ? when - now : base::TimeDelta();
   base::MessageLoop::current()->PostDelayedTask(
       FROM_HERE,
       base::Bind(
           &HttpServerPropertiesImpl::ExpireBrokenAlternateProtocolMappings,
           weak_ptr_factory_.GetWeakPtr()),
       delay);
 }
 
 }  // namespace net