Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1156563004: Convert bare pointer to scoped_ptr in net/http (Closed)

Created:
5 years, 6 months ago by ketan.goyal
Modified:
5 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert bare pointer to scoped_ptr in net/http BUG=479898 R=eroman@chromium.org Committed: https://crrev.com/d822f5ad1f78e1fb7cd5186c62ed6f4aa0149b94 Cr-Commit-Position: refs/heads/master@{#332783}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Incorporating review comments for Issue 1156563004 #

Patch Set 3 : Incorporated Review comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 1 comment Download
M net/http/http_server_properties.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties_impl.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties_manager.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
ketan.goyal
5 years, 6 months ago (2015-05-29 08:02:26 UTC) #1
ketan.goyal
Please Take look
5 years, 6 months ago (2015-05-29 08:03:02 UTC) #2
eroman
You do not appear to have signed the CLA. Please sign the Google CLA at: ...
5 years, 6 months ago (2015-05-29 22:13:06 UTC) #3
ketan.goyal
Please take look
5 years, 6 months ago (2015-06-01 07:59:50 UTC) #4
ketan.goyal
On 2015/06/01 07:59:50, ketan.goyal wrote: > Please take look Review comments Incorporated Please take look ...
5 years, 6 months ago (2015-06-03 10:54:31 UTC) #5
eroman
lgtm https://codereview.chromium.org/1156563004/diff/40001/AUTHORS File AUTHORS (right): https://codereview.chromium.org/1156563004/diff/40001/AUTHORS#newcode299 AUTHORS:299: Ketan Goyal <ketan.goyal@samsung.com> Not that this already landed ...
5 years, 6 months ago (2015-06-03 19:05:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156563004/40001
5 years, 6 months ago (2015-06-04 02:24:45 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-04 04:32:17 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 04:33:14 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d822f5ad1f78e1fb7cd5186c62ed6f4aa0149b94
Cr-Commit-Position: refs/heads/master@{#332783}

Powered by Google App Engine
This is Rietveld 408576698