Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1156533004: Enable template checking for the clang plugin on Linux. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable template checking for the clang plugin on Linux. This enables the plugin to check templated classes for the following things: - virtual functions have {virtual,override,final} correctly specified. - Refcounted types have private destructors. - WeakPtrFactory members are the last members BUG=441916 Committed: https://crrev.com/0d701b22f23d3ffc0ef40ff343a1128b64ec392d Cr-Commit-Position: refs/heads/master@{#331210}

Patch Set 1 #

Patch Set 2 : Fix bug #s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M build/common.gypi View 1 1 chunk +8 lines, -2 lines 0 comments Download
M build/config/clang/BUILD.gn View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dcheng
Seems to build, so why not.
5 years, 7 months ago (2015-05-22 18:10:49 UTC) #2
Nico
can you add a short description of the practical effects of this to the cl ...
5 years, 7 months ago (2015-05-22 18:21:40 UTC) #3
dcheng
On 2015/05/22 at 18:21:40, thakis wrote: > can you add a short description of the ...
5 years, 7 months ago (2015-05-22 18:28:15 UTC) #4
Nico
lgtm
5 years, 7 months ago (2015-05-22 18:56:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156533004/20001
5 years, 7 months ago (2015-05-22 19:00:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-23 00:10:13 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0d701b22f23d3ffc0ef40ff343a1128b64ec392d Cr-Commit-Position: refs/heads/master@{#331210}
5 years, 7 months ago (2015-05-23 00:10:55 UTC) #12
dmichael (off chromium)
5 years, 7 months ago (2015-05-23 03:53:47 UTC) #14
Message was sent while issue was closed.
Woo! Thanks for picking this up. Sorry I wasn't able to push it over the goal
line... and I'm glad nothing on Linux regressed.

Powered by Google App Engine
This is Rietveld 408576698