Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: build/common.gypi

Issue 1156533004: Enable template checking for the clang plugin on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bug #s Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2160 matching lines...) Expand 10 before | Expand all | Expand 10 after
2171 }, { # OS != "mac" or OS != "ios" 2171 }, { # OS != "mac" or OS != "ios"
2172 'clang_lib_path%': '<!(cd <(DEPTH) && pwd -P)/third_party/ll vm-build/Release+Asserts/lib/libFindBadConstructs.so', 2172 'clang_lib_path%': '<!(cd <(DEPTH) && pwd -P)/third_party/ll vm-build/Release+Asserts/lib/libFindBadConstructs.so',
2173 }], 2173 }],
2174 ], 2174 ],
2175 }, 2175 },
2176 'clang_dynlib_flags%': '-Xclang -load -Xclang <(clang_lib_path) ', 2176 'clang_dynlib_flags%': '-Xclang -load -Xclang <(clang_lib_path) ',
2177 }, { # OS == "win" 2177 }, { # OS == "win"
2178 # On Windows, the plugin is built directly into clang, so there's 2178 # On Windows, the plugin is built directly into clang, so there's
2179 # no need to load it dynamically. 2179 # no need to load it dynamically.
2180 'clang_dynlib_flags%': '', 2180 'clang_dynlib_flags%': '',
2181 }] 2181 }],
2182 # https://crbug.com/441916
2183 ['OS=="linux"', {
2184 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xc lang check-templates ',
2185 }, { # OS != "linux"
2186 'clang_plugin_args%': ''
2187 }],
2182 ], 2188 ],
2183 }, 2189 },
2184 # If you change these, also change build/config/clang/BUILD.gn. 2190 # If you change these, also change build/config/clang/BUILD.gn.
2185 'clang_chrome_plugins_flags%': 2191 'clang_chrome_plugins_flags%':
2186 '<(clang_dynlib_flags)' 2192 '<(clang_dynlib_flags)'
2187 '-Xclang -add-plugin -Xclang find-bad-constructs ', 2193 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args)' ,
2188 }], 2194 }],
2189 ['asan==1 or msan==1 or lsan==1 or tsan==1', { 2195 ['asan==1 or msan==1 or lsan==1 or tsan==1', {
2190 'clang%': 1, 2196 'clang%': 1,
2191 'use_allocator%': 'none', 2197 'use_allocator%': 'none',
2192 'use_sanitizer_options%': 1, 2198 'use_sanitizer_options%': 1,
2193 # Disable ICF in the linker to avoid debug info loss. 2199 # Disable ICF in the linker to avoid debug info loss.
2194 'gold_icf_level%': 'none', 2200 'gold_icf_level%': 'none',
2195 }], 2201 }],
2196 ['asan==1 and OS=="linux" and chromeos==0', { 2202 ['asan==1 and OS=="linux" and chromeos==0', {
2197 'use_custom_libcxx%': 1, 2203 'use_custom_libcxx%': 1,
(...skipping 4017 matching lines...) Expand 10 before | Expand all | Expand 10 after
6215 # settings in target dicts. SYMROOT is a special case, because many other 6221 # settings in target dicts. SYMROOT is a special case, because many other
6216 # Xcode variables depend on it, including variables such as 6222 # Xcode variables depend on it, including variables such as
6217 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6223 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6218 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6224 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6219 # files to appear (when present) in the UI as actual files and not red 6225 # files to appear (when present) in the UI as actual files and not red
6220 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6226 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6221 # and therefore SYMROOT, needs to be set at the project level. 6227 # and therefore SYMROOT, needs to be set at the project level.
6222 'SYMROOT': '<(DEPTH)/xcodebuild', 6228 'SYMROOT': '<(DEPTH)/xcodebuild',
6223 }, 6229 },
6224 } 6230 }
OLDNEW
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698