Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1156513006: Removing Unused Methods in TransformationMatrix (Closed)

Created:
5 years, 6 months ago by Paritosh Kumar
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing Unused Methods in TransformationMatrix Nothing calls these Methods: -map(), -mapPoint(IntPoint), -rotateFromVector(), -flipX(), -flipY(), -hasPerspective(), and -to2dTransform() This cl removes all these methods. BUG=439559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196853

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M Source/platform/transforms/TransformationMatrix.h View 1 2 5 chunks +0 lines, -16 lines 0 comments Download
M Source/platform/transforms/TransformationMatrix.cpp View 1 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156513006/1
5 years, 6 months ago (2015-06-08 13:25:05 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65665)
5 years, 6 months ago (2015-06-08 15:39:49 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156513006/20001
5 years, 6 months ago (2015-06-09 04:56:38 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/46882)
5 years, 6 months ago (2015-06-09 05:11:09 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156513006/40001
5 years, 6 months ago (2015-06-09 07:01:12 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-09 08:22:22 UTC) #13
Paritosh Kumar
Please have a look.
5 years, 6 months ago (2015-06-09 08:57:29 UTC) #15
Mike West
LGTM, try it out. :)
5 years, 6 months ago (2015-06-10 07:40:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156513006/40001
5 years, 6 months ago (2015-06-10 08:49:38 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 10:02:59 UTC) #19
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196853

Powered by Google App Engine
This is Rietveld 408576698