Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5830)

Unified Diff: chrome/browser/spellchecker/spelling_service_client.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits and rebased. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spelling_service_client.cc
diff --git a/chrome/browser/spellchecker/spelling_service_client.cc b/chrome/browser/spellchecker/spelling_service_client.cc
index f05cbc18e93431a116fa8aed4dce40deed1e2953..fa3139909a074da68423069e228fb2b42e7f58e2 100644
--- a/chrome/browser/spellchecker/spelling_service_client.cc
+++ b/chrome/browser/spellchecker/spelling_service_client.cc
@@ -115,11 +115,13 @@ bool SpellingServiceClient::IsAvailable(
ServiceType type) {
const PrefService* pref = user_prefs::UserPrefs::Get(context);
DCHECK(pref);
- // If prefs don't allow spellchecking or if the context is off the record,
- // the spelling service should be unavailable.
+ // If prefs don't allow spellchecking, if the context is off the record, or if
+ // multilingual spellchecking is enabled the spelling service should be
groby-ooo-7-16 2015/06/24 22:12:23 Why do we not want the spelling service for multil
Julius 2015/07/06 22:38:53 I believe we've talked about this (spelling server
+ // unavailable.
if (!pref->GetBoolean(prefs::kEnableContinuousSpellcheck) ||
!pref->GetBoolean(prefs::kSpellCheckUseSpellingService) ||
- context->IsOffTheRecord())
+ context->IsOffTheRecord() ||
+ chrome::spellcheck_common::IsMultilingualSpellcheckEnabled())
return false;
// If the locale for spelling has not been set, the user has not decided to

Powered by Google App Engine
This is Rietveld 408576698