chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js - Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI)

Unified Diff: chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed nits and rebased. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/spellchecker/spelling_service_client.cc ('K') | « chrome/browser/spellchecker/spelling_service_client.cc ('k') | chrome/browser/ui/webui/options/language_options_handler_common.cc » ('j') | chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

diff --git a/chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js b/chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

index 89d1ecd5f10a11157eddd07968ae735732488905..39aa9e1534a287c50843a8d9d7f30caced584601 100644

--- a/chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

+++ b/chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

@@ -36,7 +36,7 @@ TEST_F('LanguagesOptionsDictionaryDownloadWebUITest',

'testdictionaryDownloadSuccess',

function() {

options.LanguageOptions.onDictionaryDownloadSuccess('en-US');

- expectFalse($('language-options-spell-check-language-message').hidden);

+ expectFalse($('spellcheck-language-message').hidden);

expectTrue($('language-options-dictionary-downloading-message').hidden);

expectTrue($('language-options-dictionary-download-failed-message').hidden);

expectTrue(

@@ -49,7 +49,7 @@ TEST_F('LanguagesOptionsDictionaryDownloadWebUITest',

'testdictionaryDownloadProgress',

function() {

options.LanguageOptions.onDictionaryDownloadBegin('en-US');

- expectTrue($('language-options-spell-check-language-message').hidden);

+ expectTrue($('spellcheck-language-message').hidden);

expectFalse($('language-options-dictionary-downloading-message').hidden);

expectTrue($('language-options-dictionary-download-failed-message').hidden);

expectTrue(

@@ -66,7 +66,7 @@ TEST_F('LanguagesOptionsDictionaryDownloadWebUITest',

// First failure shows a short error message.

options.LanguageOptions.onDictionaryDownloadFailure('en-US');

- expectTrue($('language-options-spell-check-language-message').hidden);

+ expectTrue($('spellcheck-language-message').hidden);

expectTrue($('language-options-dictionary-downloading-message').hidden);

expectFalse($('language-options-dictionary-download-failed-message').hidden);

expectTrue(

@@ -74,14 +74,14 @@ TEST_F('LanguagesOptionsDictionaryDownloadWebUITest',

// Second and all following failures show a longer error message.

options.LanguageOptions.onDictionaryDownloadFailure('en-US');

- expectTrue($('language-options-spell-check-language-message').hidden);

+ expectTrue($('spellcheck-language-message').hidden);

expectTrue($('language-options-dictionary-downloading-message').hidden);

expectFalse($('language-options-dictionary-download-failed-message').hidden);

expectFalse(

$('language-options-dictionary-download-fail-help-message').hidden);

options.LanguageOptions.onDictionaryDownloadFailure('en-US');

- expectTrue($('language-options-spell-check-language-message').hidden);

+ expectTrue($('spellcheck-language-message').hidden);

expectTrue($('language-options-dictionary-downloading-message').hidden);

expectFalse($('language-options-dictionary-download-failed-message').hidden);

expectFalse(