Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/spellchecker/spellcheck_service_unittest.cc

Index: chrome/browser/spellchecker/spellcheck_service_unittest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_service_unittest.cc b/chrome/browser/spellchecker/spellcheck_service_unittest.cc
index f2fd9f0fff6ec1c0396a87c99f5a38026f8f5f6a..0dca3e78874d7b2e545bbd28c1c9a7d24c240954 100644
--- a/chrome/browser/spellchecker/spellcheck_service_unittest.cc
+++ b/chrome/browser/spellchecker/spellcheck_service_unittest.cc
@@ -30,78 +30,3 @@ class SpellcheckServiceTest : public testing::Test {
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfile profile_;
 };
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages1) {

[groby-ooo-7-16, 2015/06/18 00:44:30]

This is not good - in general, Chrome prefers unit tests over browser tests. Is
there a way to avoid moving these into browsertests?

[Julius, 2015/06/24 21:17:58]

Done.

-  std::vector<std::string> accept_languages;
-  accept_languages.push_back("en");
-  accept_languages.push_back("en-US");
-  std::vector<std::string> languages;
-
-  SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, "en-US", &languages);
-
-  EXPECT_EQ(1U, languages.size());
-  EXPECT_EQ("en-US", languages[0]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages2) {
-  std::vector<std::string> accept_languages;
-  accept_languages.push_back("en-US");
-  accept_languages.push_back("en");
-  std::vector<std::string> languages;
-
-  SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, "en-US", &languages);
-
-  EXPECT_EQ(1U, languages.size());
-  EXPECT_EQ("en-US", languages[0]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages3) {
-  std::vector<std::string> accept_languages;
-  accept_languages.push_back("en");
-  accept_languages.push_back("en-US");
-  accept_languages.push_back("en-AU");
-  std::vector<std::string> languages;
-
-  SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, "en-US", &languages);
-
-  EXPECT_EQ(2U, languages.size());
-
-  std::sort(languages.begin(), languages.end());
-  EXPECT_EQ("en-AU", languages[0]);
-  EXPECT_EQ("en-US", languages[1]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages4) {
-  std::vector<std::string> accept_languages;
-  accept_languages.push_back("en");
-  accept_languages.push_back("en-US");
-  accept_languages.push_back("fr");
-  std::vector<std::string> languages;
-
-  SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, "en-US", &languages);
-
-  EXPECT_EQ(2U, languages.size());
-
-  std::sort(languages.begin(), languages.end());
-  EXPECT_EQ("en-US", languages[0]);
-  EXPECT_EQ("fr", languages[1]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages5) {
-  std::vector<std::string> accept_languages;
-  accept_languages.push_back("en");
-  accept_languages.push_back("en-JP");  // Will not exist.
-  accept_languages.push_back("fr");
-  accept_languages.push_back("aa");  // Will not exist.
-  std::vector<std::string> languages;
-
-  SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, "fr", &languages);
-
-  EXPECT_EQ(1U, languages.size());
-  EXPECT_EQ("fr", languages[0]);
-}