Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/spellchecker/spellcheck_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellchecker/spellcheck_service.h"
 
 #include <algorithm>
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/spellchecker/feedback_sender.h"
@@ skipping 12 matching lines @@
   void SetUp() override {
     // Use SetTestingFactoryAndUse to force creation and initialization.
     SpellcheckServiceFactory::GetInstance()->SetTestingFactoryAndUse(
         &profile_, &BuildSpellcheckService);
   }
 
  private:
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfile profile_;
 };
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages1) {

[groby-ooo-7-16, 2015/06/18 00:44:30]

This is not good - in general, Chrome prefers unit tests over browser tests. Is
there a way to avoid moving these into browsertests?

[Julius, 2015/06/24 21:17:58]

Done.

-  std::vector<std::string> accept_languages;
-  accept_languages.push_back("en");
-  accept_languages.push_back("en-US");
-  std::vector<std::string> languages;
-
-  SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, "en-US", &languages);
-
-  EXPECT_EQ(1U, languages.size());
-  EXPECT_EQ("en-US", languages[0]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages2) {
-  std::vector<std::string> accept_languages;
-  accept_languages.push_back("en-US");
-  accept_languages.push_back("en");
-  std::vector<std::string> languages;
-
-  SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, "en-US", &languages);
-
-  EXPECT_EQ(1U, languages.size());
-  EXPECT_EQ("en-US", languages[0]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages3) {
-  std::vector<std::string> accept_languages;
-  accept_languages.push_back("en");
-  accept_languages.push_back("en-US");
-  accept_languages.push_back("en-AU");
-  std::vector<std::string> languages;
-
-  SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, "en-US", &languages);
-
-  EXPECT_EQ(2U, languages.size());
-
-  std::sort(languages.begin(), languages.end());
-  EXPECT_EQ("en-AU", languages[0]);
-  EXPECT_EQ("en-US", languages[1]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages4) {
-  std::vector<std::string> accept_languages;
-  accept_languages.push_back("en");
-  accept_languages.push_back("en-US");
-  accept_languages.push_back("fr");
-  std::vector<std::string> languages;
-
-  SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, "en-US", &languages);
-
-  EXPECT_EQ(2U, languages.size());
-
-  std::sort(languages.begin(), languages.end());
-  EXPECT_EQ("en-US", languages[0]);
-  EXPECT_EQ("fr", languages[1]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages5) {
-  std::vector<std::string> accept_languages;
-  accept_languages.push_back("en");
-  accept_languages.push_back("en-JP");  // Will not exist.
-  accept_languages.push_back("fr");
-  accept_languages.push_back("aa");  // Will not exist.
-  std::vector<std::string> languages;
-
-  SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, "fr", &languages);
-
-  EXPECT_EQ(1U, languages.size());
-  EXPECT_EQ("fr", languages[0]);
-}